Homework answers / question archive / Reviewing other developer’s work is essential

Reviewing other developer’s work is essential

Computer Science

Share With

Reviewing other developer’s work is essential. Reviewing the work of others makes both the reviewer and the reviewee better developers by allowing you to see how others might solve the same problem. It also ensures that standards are adhered to and offer the potential to catch logic errors that would otherwise end up in production.  Peer code reviews are typically done by a pull request.  The following video will outline how this is done and provide some helpful advice on completing your homework for this week.  Please make sure you are following the steps outlined in this video.

https://bellevue.mediaspace.kaltura.com/media/Code+Review+and+Pull+Request/1_uegwl6fu

# This is a header for the application
# You should read this header and insert your name and your date below as part of the peer review
# This is a typical part of any program
# Author: <author>
# Creation Date: <date>
# Below is a simple program with several.  You need to identify the issues and correct them.

import random
import time

def displayIntro():
print('''You are in a land full of dragons. In front of you,
you see two caves. In one cave, the dragon is friendly
and will share his treasure with you. The other dragon
is greedy and hungry, and will eat you on sight.''')
print()

def chooseCave():
   cave = ''
       while cave != '1' and cave != '2':
           print('Which cave will you go into? (1 or 2)')
           cave = input()

   return caves

def checkCave(chosenCave):
   print('You approach the cave...')
   #sleep for 2 seconds
   time.sleep(2)
   print('It is dark and spooky...')
   #sleep for 2 seconds
   time.sleep(3)
   print('A large dragon jumps out in front of you! He opens his jaws and...')
   print()
   #sleep for 2 seconds
   time.sleep(2)
   friendlyCave = random.randint(1, 2)

   if chosenCave == str(friendlyCave):
       print('Gives you his treasure!')
   else:
       print 'Gobbles you down in one bite!'


displayIntro()
caveNumber = choosecave()
checkCave(caveNumber)
   
print("Thanks for planing")